[FEAT] Fill method + Chapter 16 data - #1379
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 33.3% fully typed (1 / 3)
Patch symbol details
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b5405bb. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/fill #1379 +/- ##
================================================
+ Coverage 91.78% 91.80% +0.02%
================================================
Files 96 96
Lines 5488 5502 +14
Branches 707 708 +1
================================================
+ Hits 5037 5051 +14
Misses 327 327
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@henrydingliu can you work off a branch on casact so I can switch to it a bit easier? Are we still doing the check if the triangle is full? I think it could be a useful hyper parameter. The current implementation checks for nans only? So while the lower half will be nan, nothing is filled, but if the upper half has a nan, it will stay as nan? Anyways I could be missing something as I am just staring at the code without being able to play with it. |

Summary of Changes
Prep for Friedland Chapter 16
Triangle.fillmethod, with testsRelated GitHub Issue(s)
closes #1360
AI/LLM Usage
I used AI to find the incorrect data points and to debug
Additional Context for Reviewers
Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist
Note
Low Risk
Small additive API with tests and sample-data fixes; no changes to reserving or auth paths.
Overview
Adds
Triangle.fill, which sets every valid (non-masked) cell to a scalar while preserving the triangle’s NaN structure vianan_triangle. Default is copy-out;inplace=Truemutates values in place using the active array backend.Tests cover a sliced triangle and a chainladder
full_triangle_.friedland_autoprop.csvis corrected for Friedland Chapter 16 prep (paid/incurred typos on two 2001 origin rows).Reviewed by Cursor Bugbot for commit 40e843b. Bugbot is set up for automated code reviews on this repo. Configure here.