[FEAT] Adding Frieland Chapter 14 - #1369
henrydingliu wants to merge 4 commits into
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 96 96
Lines 5477 5477
Branches 706 706
=======================================
Hits 5026 5026
Misses 327 327
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e29b075. Configure here.

Summary of Changes
Adding Friedland Chapter 14
Correcting some typos in the data file
Related GitHub Issue(s)
#588
AI/LLM Usage
most of the code was copy and paste from prior chapters
i used ai to turn screenshots of the friedland text into hardcoded arrays for asserting
Additional Context for Reviewers
Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist
Note
Low Risk
Documentation and bundled sample-data corrections only; no library API or runtime behavior changes beyond users of the corrected CSV.
Overview
Adds Friedland Chapter 14 documentation (salvage/subrogation recoveries and reinsurance) as a new notebook wired into
docs/_toc.yml. The notebook walks through Exhibit I (development, chain-ladder, ratio-based ultimate S&S, recoverables) and Exhibit II (QS/XOL samples plus stop-loss treaty tables), withassertchecks against textbook figures.Corrects
friedland_auto_salsub.csv: reported/received salvage and related amounts are fixed so accident-year triangles follow the intended calendar-year progression (e.g. latest-age cells no longer carry values that belonged to other years/rows).Reviewed by Cursor Bugbot for commit 9b9fdee. Bugbot is set up for automated code reviews on this repo. Configure here.