Skip to content

[FEAT] Adding Frieland Chapter 14 - #1369

Open
henrydingliu wants to merge 4 commits into
casact:mainfrom
henrydingliu:feature/friedland_chapter_14
Open

henrydingliu wants to merge 4 commits into
casact:mainfrom
henrydingliu:feature/friedland_chapter_14

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Sep 16, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Adding Friedland Chapter 14
Correcting some typos in the data file

Related GitHub Issue(s)

#588

AI/LLM Usage

most of the code was copy and paste from prior chapters
i used ai to turn screenshots of the friedland text into hardcoded arrays for asserting

Additional Context for Reviewers

Submitter's Checklist

  • I have reviewed and am adhering to the standards outlined in the project Governing Doc.
  • The PR subject title summarizes the changes, with one proper prefix ([FIX], [FEAT], [DOCS], [TST], [CHORE], or [BRK]).
  • I am a human (not a bot), and this PR form is written by a human.

Reviewer's Checklist

  • The implementation addresses the associated issue(s).
  • The implementation is appropriate, maintainable, and follows ARCHITECTURE.md.
  • PR subject title has the proper prefix and the subject is appropriate.
  • Relevant issue(s) are linked.
  • AI/LLM usage is disclosed and appropriate.
  • Documentation and tests are appropriate.
  • CI tests passed, or any failures are acceptable.
  • Leave a comment with the final recommendation (e.g. approve as is, request a secondary review, or flag an area for more review).

Note

Low Risk
Documentation and bundled sample-data corrections only; no library API or runtime behavior changes beyond users of the corrected CSV.

Overview
Adds Friedland Chapter 14 documentation (salvage/subrogation recoveries and reinsurance) as a new notebook wired into docs/_toc.yml. The notebook walks through Exhibit I (development, chain-ladder, ratio-based ultimate S&S, recoverables) and Exhibit II (QS/XOL samples plus stop-loss treaty tables), with assert checks against textbook figures.

Corrects friedland_auto_salsub.csv: reported/received salvage and related amounts are fixed so accident-year triangles follow the intended calendar-year progression (e.g. latest-age cells no longer carry values that belonged to other years/rows).

Reviewed by Cursor Bugbot for commit 9b9fdee. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 15.0% of exported symbols fully typed (208 / 1383)

Known Ambiguous Unknown Total
Project (head) 208 111 1064 1383

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 328
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread docs/friedland/chapter_14.ipynb
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.76%. Comparing base (a9c1326) to head (9b9fdee).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1369   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files          96       96           
  Lines        5477     5477           
  Branches      706      706           
=======================================
  Hits         5026     5026           
  Misses        327      327           
  Partials      124      124           
Flag Coverage Δ
unittests 91.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e29b075. Configure here.

Comment thread docs/friedland/chapter_14.ipynb
@henrydingliu
henrydingliu marked this pull request as ready for review September 16, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant