Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defserverbuiltmainby callingevalon a(defn main …)form at expansion time. It was the macro's last expression, so the macro now returns that form instead, and the compiler definesmainas it would any other expansion. Usage is unchanged.The reason is portability: a compiler that expands macros ahead of time and keeps compile-time code apart from the program can't
evala static definition in the middle of expansion. On metacarp,defserverfailed withunknown compile-time function: App.create. With this change it expands there.webstill doesn't build on metacarp, because of an unrelated type-inference error inCacheControl.parse.Tests.
test/web.carpis 408/0 andtest/websocket.carpis 155/0. The smoke test and gendocs pass.