fix(react): regenerate stale react.api.md after @types/react bump#166
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependabot #164 (acfef7f) merged the minor/patch group — including @types/react 19.2.14 -> 19.2.17 — without regenerating the API Extractor report, so `main`'s `api:check` gate is currently broken: every PR fails report-freshness until the report is refreshed. @types/react@19.2.17 re-exports the JSX namespace from `react` instead of `react/jsx-runtime`, so the four exported components' return types now render as `react.JSX.Element` rather than `react_jsx_runtime.JSX.Element`. Semantically identical public API — purely a type-representation change. Regenerated via `pnpm api`; `pnpm api:check` now passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
blove
force-pushed
the
claude/deps-minor-patch-sweep
branch
from
4b6a16a to
2aa3eb6
Compare
blove
changed the title
Contributor
Vercel preview readyPreview: https://pretable-nk57p1ab1-cacheplane.vercel.app Updated automatically by the |
This was referenced Jun 6, 2026
blove
added a commit
that referenced
this pull request
Jun 6, 2026
…actually produces Repairs main's now-REQUIRED `API Extractor — report freshness` gate, which is red on cf206ce (#167) and consequently blocks every PR including this one. Evidence that the `react.JSX.Element` form (not `react_jsx_runtime.JSX.Element`) is correct for the committed lockfile (@types/react@19.2.17 only): - `cf206ce` (main HEAD) CI run 27074416896 → "API Extractor — report freshness: failure". - PR #168 CI → same job fails (this branch carries main's react.api.md unchanged). - Clean repro == CI (`rm -rf node_modules && pnpm install --frozen-lockfile`, only @types/react@19.2.17 resolved) → `pnpm api:check` regenerates the `react.JSX.Element` form and fails against the committed `react_jsx_runtime` form. After this commit it passes (exit 0). #167 produced the `react_jsx_runtime` form by regenerating against a stale @types/react@19.2.14 (the pre-#164 version), which is why it regressed #166. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
blove
added a commit
that referenced
this pull request
Jun 6, 2026
…168) * docs(spec): headless engine docs (@pretable/core) design Brainstormed design for the deferred @pretable/core headless-engine docs: a new 'Headless engine' docs section (5 pages) plus one runnable React custom-renderer example. Captures the load-bearing accuracy constraint — core is a state/row-model engine, not a renderer; visibleRows is the filtered+sorted set, not a viewport window — so the docs and example don't claim virtualization the engine doesn't do. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(plan): headless engine docs (@pretable/core) implementation plan 12-task TDD plan: add @pretable/core to the website, build a createGrid + useSyncExternalStore custom-renderer example (with RTL test), embed it live via a registered prop-less MDX wrapper, write 5 MDX pages, wire nav + cross-links, verify. Resolves the embedding-mechanism unknown from the spec (compileMDX can't resolve MDX imports, so live demos must be prop-less registered components). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(website): depend on @pretable/core for headless docs example Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(website): headless example fixture data + columns Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(website): headless custom-renderer demo component + test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(website): headless example defineExample + display source Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(website): register HeadlessExample MDX component Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(website): headless example shows its real demo source * docs(website): headless engine overview page * docs(website): headless getting-started page with live example * docs(website): headless snapshot & subscribe page * docs(website): headless actions/mutations page * docs(website): headless API reference page * docs(website): wire headless nav section + cross-links * docs(website): context for tri-state type + tighten subscribe wording Review polish: give PretableRowSelectionTriState a one-line usage note (was an orphan in the Types section) and clarify that the subscribe listener fires on each *effective* state change (no-op mutations don't notify). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(website): prettier-format headless pages, plan, and spec The root `format` gate (prettier --check .) flagged the new MDX docs and the plan/spec markdown. Formatted; no content change. * fix(react): regenerate react.api.md to the form @types/react@19.2.17 actually produces Repairs main's now-REQUIRED `API Extractor — report freshness` gate, which is red on cf206ce (#167) and consequently blocks every PR including this one. Evidence that the `react.JSX.Element` form (not `react_jsx_runtime.JSX.Element`) is correct for the committed lockfile (@types/react@19.2.17 only): - `cf206ce` (main HEAD) CI run 27074416896 → "API Extractor — report freshness: failure". - PR #168 CI → same job fails (this branch carries main's react.api.md unchanged). - Clean repro == CI (`rm -rf node_modules && pnpm install --frozen-lockfile`, only @types/react@19.2.17 resolved) → `pnpm api:check` regenerates the `react.JSX.Element` form and fails against the committed `react_jsx_runtime` form. After this commit it passes (exit 0). #167 produced the `react_jsx_runtime` form by regenerating against a stale @types/react@19.2.14 (the pre-#164 version), which is why it regressed #166. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs
main. Dependabot #164 (acfef7f) merged the minor/patch group — including@types/react19.2.14→19.2.17 — without regenerating the API Extractor report.main'sapi:checkgate is therefore currently broken: every PR will failAPI Extractor — report freshnessuntil the report is refreshed. (#164's ownapi:checkwas failing for this reason but evidently wasn't a required check, so it merged anyway.)Fix
@types/react@19.2.17re-exports the JSX namespace fromreactinstead ofreact/jsx-runtime, so the four exported components' return types now render asreact.JSX.Elementrather thanreact_jsx_runtime.JSX.Element. Semantically identical public API — purely a type-representation change.Single-file diff:
packages/react/react.api.md(5 lines), regenerated viapnpm api.pnpm api:checkpasses locally.🤖 Generated with Claude Code