Fix flaky response-body-fail test - #143
Merged
yoshuawuyts merged 1 commit intoSep 2, 2026
Merged
Conversation
This was referenced Sep 2, 2026
yoshuawuyts
approved these changes
Sep 2, 2026
yoshuawuyts
left a comment
yoshuawuyts
left a comment
Member
There was a problem hiding this comment.
This looks reasonable to me; thank you for filing this!
Contributor
|
I was just thinking this looked familiar and it turns out I had run into that on #140 as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
http_serverwould fail ~1/10 times when running locally for me and failed once on CI here. This would be for testing the case where the server hits an error while streaming the body. The issue seems to be that occasionally theureqcall will come backOkand the error is only exposed while reading the body.I'm not sure why
ureqis non-deterministic in where it reports the error, but it seems entirely reasonable to only report it when streaming the body given that the server only errors when writing the body. So this just modifies the test to pass in that case as well.