Compute "Sum Total" measurements across benchmarks#325
Merged
Conversation
Instead of requiring exactly two engines, produce an `EffectSize` for each pair of engines present in each group of measurements. Fewer than two engines is still an error.
posborne
approved these changes
Jul 9, 2026
Collaborator
|
Thanks @fitzgen changes make sense and look good to me. |
When not writing raw results, sum each sample's count across all benchmarks into
new "Sum Total" measurements. The `summarize` and `effect_size` `write`
functions now always sort these totals first.
Example `effect_size` output:
```
compilation :: cycles :: Sum Total
No difference in performance.
[42440 2078805.99 22345522] bar.dylib
[42143 2118448.96 21992615] foo.dylib
compilation :: cycles :: benchmarks/rust-protobuf/benchmark.wasm
No difference in performance.
[254047 263161.00 276396] bar.dylib
[278563 310704.33 339043] foo.dylib
compilation :: cycles :: benchmarks/libsodium/libsodium-onetimeauth7.wasm
No difference in performance.
[313024 335259.00 362670] bar.dylib
[284558 291442.33 299564] foo.dylib
...
```
Example `summary` output:
```
compilation
Sum Total
cycles
[43667 2067328.82 21894814] /Users/n.fitzgerald/scratch/sightglass-analysis-tweaks/engines/wasmtime/libengine.dylib
benchmarks/blake3-scalar/benchmark.wasm
cycles
[202798 215967.20 224731] /Users/n.fitzgerald/scratch/sightglass-analysis-tweaks/engines/wasmtime/libengine.dylib
benchmarks/bz2/benchmark.wasm
cycles
[410880 441370.60 496848] /Users/n.fitzgerald/scratch/sightglass-analysis-tweaks/engines/wasmtime/libengine.dylib
benchmarks/cm-online-stats/cm-online-stats.wasm
cycles
[65024 68305.20 70651] /Users/n.fitzgerald/scratch/sightglass-analysis-tweaks/engines/wasmtime/libengine.dylib
...
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #324 (which is the first commit)
When not writing raw results, sum each sample's count across all benchmarks into new "Sum Total" measurements. The
{summarize,effect_size}::writefunctions always sort these totals first.Example
effect_sizeoutput:Example
summaryoutput: