Guard against nil proto config in loadConfig#148
Merged
Conversation
proto.GetProtoConfig() returns nil when the proto Gazelle language is not loaded alongside buf. Guard the return value to prevent a nil pointer dereference panic. Fixes bufbuild#147
|
|
pkwarren
approved these changes
May 25, 2026
pkwarren
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proto.GetProtoConfig()returns nil when the proto Gazelle language is not loaded alongside buf. This causes a nil pointer dereference panic inloadConfigatgazelle/buf/config.go:117.This can happen when using
aspect_gazelle_prebuilt(or any Gazelle binary) withbufenabled butprotonot in the languages list.Fix
Guard the
proto.GetProtoConfig()return value with a nil check. When nil, log a message and skip thestrip_import_prefixconfiguration.Fixes #147