chore: adopt @btravstack/lefthook; enable oxfmt sortImports#334
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates repo tooling to use the shared @btravstack hook preset and re-enables automatic import sorting via oxfmt (fixing a config key that no longer applies), which results in repo-wide import reordering with no intended runtime behavior changes.
Changes:
- Adopt
@btravstack/lefthookand switchlefthook.ymlto extend the shared base while layering a repo-specificpnpm-lock.yamlformat exclude. - Fix oxfmt configuration by enabling
sortImports: trueat the top level (restoring import sorting). - Apply the resulting import reordering/whitespace normalization across packages, examples, docs, and tests; add a patch changeset for the fixed-version core package set.
Reviewed changes
Copilot reviewed 72 out of 73 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds @btravstack/lefthook to the workspace catalog and release-age exclusions. |
| pnpm-lock.yaml | Locks the new @btravstack/lefthook catalog entry and dependency graph updates. |
| package.json | Adds @btravstack/lefthook as a root devDependency (hooks preset). |
| lefthook.yml | Extends the shared lefthook base config; layers repo-specific format excludes. |
| knip.json | Ignores @btravstack/lefthook in dependency usage checks. |
| .oxfmtrc.json | Enables sortImports using the current oxfmt config shape. |
| .changeset/adopt-lefthook-oxfmt.md | Patch changeset to ship the tooling/config update (fixed group bumps together). |
| packages/worker/src/workflow.ts | Import order updated by oxfmt sortImports. |
| packages/worker/src/workflow.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/workflow-proxy.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/workflow-options.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/workflow-errors.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/worker.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/worker.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/types-inference.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/internal.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/handlers.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/worker/src/handlers.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/errors.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/contract-errors.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/continue-as-new.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/child-workflow.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/worker/src/child-workflow.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/cancellation.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/worker/src/cancellation.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/activity.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/activity.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/activity-contract-errors.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/activities-proxy.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/activities-proxy.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/tests/worker.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/tests/time-skipping.inprocess.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/tests/test.workflows.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/worker/src/tests/inprocess.workflows.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/worker/src/tests/inprocess.contract.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/testing/src/global-setup.spec.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/testing/src/extension.spec.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/contract/src/types.spec.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/contract/src/types-inference.spec.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/contract/src/result-async.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/contract/src/helpers.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/contract/src/format.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/contract/src/errors.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/contract/src/errors.spec.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| packages/contract/src/builder.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/contract/src/builder.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/types.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/types-inference.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/schedule.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/schedule.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/internal.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/interceptors.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/errors.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/errors.spec.ts | Import order/comment placement updated by oxfmt sortImports. |
| packages/client/src/client.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/client.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| packages/client/src/tests/client.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| examples/order-processing-worker/src/integration.spec.ts | Import order/spacing updated by oxfmt sortImports. |
| examples/order-processing-worker/src/infrastructure/adapters/shipping.adapter.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/infrastructure/adapters/payment.adapter.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/infrastructure/adapters/inventory.adapter.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/domain/usecases/reserve-inventory.usecase.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/domain/usecases/process-payment.usecase.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/domain/usecases/create-shipment.usecase.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/domain/entities/order.schema.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/dependencies.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/application/workflows.ts | Import order updated by oxfmt sortImports. |
| examples/order-processing-worker/src/application/worker.ts | Import order/spacing updated by oxfmt sortImports. |
| examples/order-processing-worker/src/application/activities.ts | Import order/spacing updated by oxfmt sortImports. |
| examples/order-processing-contract/src/contract.ts | Whitespace/import grouping updated by oxfmt sortImports. |
| examples/order-processing-client/src/client.ts | Import order/spacing updated by oxfmt sortImports. |
| docs/scripts/copy-docs.ts | Minor whitespace normalization in import block. |
| docs/.vitepress/theme/index.ts | Whitespace/import grouping updated by oxfmt sortImports. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
…fmt) - @btravstack/tsconfig 0.2.0: verbatimModuleSyntax + moduleDetection:force, drop types:["node"]. oxlint --fix added `type` specifiers to type-only imports so the non-eliding verbatimModuleSyntax build resolves. - @btravstack/oxlint 0.2.1: consistent-type-imports (inline, disallowTypeAnnotations off — idiomatic `vi.importActual<typeof import()>` mocks stay) - @btravstack/lefthook: lefthook.yml extends the shared base + local excludes - .oxfmtrc.json: organizeImports -> sortImports (was silently off)
btravers
force-pushed
the
chore/adopt-lefthook-oxfmt
branch
from
July 24, 2026 07:28
2f968f3 to
42e18f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the tools-removal (#332, merged).
lefthook.ymlnow extends the shared@btravstack/lefthookbase (format/lint/commit-msg); the repo'spnpm-lock.yamlformat-exclude is layered on top..oxfmtrc.jsonusedorganizeImports, a key oxfmt 0.58 dropped, so import sorting was silently off. Switched tosortImports: true; reorders imports repo-wide (patch changeset on the fixed group).Gate green: changeset, typecheck/build, lint, format, knip, audit.