Repository navigation
v1.2.0: Unicode styles, ancient numerals, British and, nth/compact, vinculum Roman, playground polish - #13
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
- Render site/og.png from og.svg (Slack, X, LinkedIn ignore SVG og:image) - Point og:image / twitter:image at the PNG - Add npm run site:og (scripts/build-og.sh, headless Chrome) - GitHub repo description, homepage and topics set via gh repo edit
bd60cea to
892f55b
Compare
✅ Deploy Preview for numberstring ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
… zh/ja (v1.2.0) - British 'and' option on numberstring()/ordinal() - nth(): 1st 2nd 3rd 11th 112th - compact(): 1.5K 2.3B, digits and long options - fancy(): circled, superscript, subscript, fullwidth, bold, doublestruck, sans, monospace, keycap, braille digit styles - numerals.js: egyptian, babylonian, mayan, greek, tally - chinese()/japanese() formal option for 大写 / 大字 financial numerals - Playground rows for all of the above; ASCII art links home - Codex fixes: bahasa alias, converter option types, safe hash decode - Types, README, CHANGELOG 1.2.0, version bump; still zero dependencies
brianfunk
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6590cd2135
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- compact(): ignore leading zeros when picking a scale; keep 1000Dc at the upper bound instead of returning false - decimal(): forward the 'and' option to the integer part - chinese(): emit 零 between a higher myriad group and a lower group that starts below the thousands place (一万零一), formal and plain
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3448cefc1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c822d9e398
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…lias; playground tweaks
- scientific(): exact mantissa, unicode/caret/e/words formats, digits rounding
- radix() with binary/octal/hex helpers; prefix, upper, pad options
- bytes(): decimal or binary units, long form
- clock(): clock-face emoji for hours or H:MM
- fancy('emoji') alias of keycap
- Playground: fraction row shows words only, year row from 1, new rows
|
@codex review |
…all-zero strings digit by digit
|
@codex review |
…sentence); bits() split from bytes()
… CONTRIBUTING, package metadata, site meta, OG image)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d1bbd09e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…keep guard digits when rounding; sync lockfile to 1.2.0
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88a3a437f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…CAP_STYLES lists aliases
|
@codex review |
|
@codex review |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68d2466cb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Started as PR polish on top of #12; grew into the 1.2.0 feature release. Still zero runtime dependencies.
New in the library
capnow takes sentence, camel, pascal, snake, kebab, constant, dot:numberstring(123, { cap: 'snake' })→ one_hundred_twenty_three.andoption —numberstring(1001, { and: true })→ "one thousand and one";ordinal()honors it too.nth(n)—1st,22nd,113th.compact(n, opt)—1.5K,2.3B,1Sx;digitsandlong("1.5 million") options.fancy(n, style)— ④② ⁴² ₄₂ ４２ 𝟒𝟐 𝟜𝟚 𝟦𝟤 𝟺𝟸 4️⃣2️⃣ ⠼⠙⠃.numerals.js) —egyptian(),babylonian(),greek()(Mayan and tally were tried and dropped: no macOS font).chinese(n, { formal: true })→ 壹仟零壹,japanese(n, { formal: true })→ 壱千壱.nato(n)(aliasesicao,military) — ICAO radiotelephony numerals: 1984 → "wun niner ait fower", 2500 → "too tousand fife hundred", 121.5 → "wun too wun decimal fife".morse(n)— International Morse code digits.telephone(n, { oh: true })says "oh" for zero.scientific(n)— exact-mantissa notation: 1984 → "1.984 × 10³"; caret, e, and words formats.binary(),octal(),hex(),radix(n, base)— other bases, with prefix/upper/pad.bytes(n)andbits(n)— 1.5 KB, 1.5 KiB, 1.5 Mb, or "one point five kilobytes".clock(time)— 🕒 🕞 clock faces for an hour or H:MM.fancy('emoji')alias for keycap.roman()vinculum notation above 3999, up to 3,999,999,999.bahasaalias for Indonesian.Playground
og.png) withnpm run site:ogto re-render; OG/Twitter tags point at it.Codex findings from #12, addressed here
LanguageConverterno longer advertisescapon converters that ignore it; es/pt keep it, zh/ja gainformal.bahasaalias added to the runtime map to match the declared union.decodeURIComponenton the hash is wrapped in try/catch.Also
gh repo edit(already live).index.d.ts(checked withtsc --strict), CLAUDE.md.Test plan
npm run lintcleannpm test788 passing, including a fuzz suite over every exporttsc --noEmit --strict index.d.tsclean