chore(discover): remove the duplicate builders filter implementation - #377
Merged
Conversation
#374 was merged so the contributor's work is recorded, but the shared filter rail had already landed in #371, so everything in it was a second copy of something the tree already had. This removes that copy. - builders-filter-rail and builders-filter-sheet duplicated FilterRail and FilterSheet, which both directories already share. Neither was imported anywhere. - GenericFilterRail sat beside a FilterRail that is already generic. - lib/api/users.ts hand wrote BuilderListItemDto and BuilderFiltersDto, which use-builders.ts derives from the generated schema. Hand written copies drift silently when the backend changes; the derived ones cannot. - IMPLEMENTATION.md and BUILDER_FILTERS_SUMMARY.md were working notes, and .vscode/settings.json is editor config. Nothing outside these files referenced any of them, so this is a straight removal. filter-rail.tsx is byte identical to its state before #374. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #374, which was merged so the contributor's work is recorded even though the shared rail had already landed in #371.
Every file #374 added was a second copy of something the tree already had, and nothing outside those files referenced any of them:
builders-filter-rail.tsxFilterRail(#371), shared by both directoriesbuilders-filter-sheet.tsxFilterSheet(#371). Never importedGenericFilterRailinfilter-rail.tsxFilterRail, which is already genericlib/api/users.tsuse-builders.ts, deriving DTOs from the generated schemaIMPLEMENTATION.md,BUILDER_FILTERS_SUMMARY.md.vscode/settings.json735 deletions, matching #374's 735 additions exactly.
filter-rail.tsxis byte identical to its state before #374.The hand written DTOs are the part worth calling out. They would have drifted silently the next time the backend changed, while
Schemas['BuilderListItemDto']cannot.tsc,eslintandbuildall pass, and/buildersstill prerenders.🤖 Generated with Claude Code