Feat/builders directory grid - #372
Open
Shadow-MMN wants to merge 2 commits into
Open
Conversation
The doc comment referenced `Schemas['UserDirectoryItemDto']`, which does not exist in the generated schema. The real name is `BuilderListItemDto`.
Adds the builders directory page so the landing "View all builders" CTA no longer 404s. The page fetches paginated data from GET /users/directory with search and page/limit support, rendering BuilderCard in a responsive grid with skeleton, error, and empty states. - use-builders.ts: query hook derived from generated BuilderListItemDto - to-builder-directory-card.ts: separate mapper (no followers/projects) - builders-grid.tsx: grid + pagination, modelled on projects-grid - builders-view.tsx: owns search, debounce, and page state - app/builders/page.tsx: route with metadata, header, footer Filters and sort are out of scope and will land in follow-up issues.
|
@Shadow-MMN is attempting to deploy a commit to the Threadflow Team on Vercel. A member of the Team first needs to authorize it. |
|
@Shadow-MMN Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Benjtalkshow
requested changes
Aug 28, 2026
Contributor
There was a problem hiding this comment.
Thanks! lint, tsc and build pass here.
Please fix:
builders-view.tsx:60passes() => {}andfiltersOpen={false}, so the Filters button and mobile filter icon do nothing.builder-card.tsx:103always draws the footer divider, but the mapper sets nofollowersorprojects, so cards end with a stray rule.to-builder-directory-card.ts:23builds/builders/nullwhenusernameis null.
#370 and #371 add this same page. Please hold before rebasing.
Add a screenshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364
feat(builders): add /builders route with directory grid
The landing page "View all builders" button links to
/builders, which 404s today. This PR adds the route with a paginated directory grid.What changed
app/builders/page.tsx- New route matching the shape ofapp/projects/page.tsx(metadata, SiteHeader, BuildersView, SiteFooter)components/discover/use-builders.ts- Query hook forGET /users/directorywithpage,limit, andsearchparams. Row type derived fromSchemas['BuilderListItemDto']components/discover/to-builder-directory-card.ts- Separate mapper fromto-builder-card.ts(which maps/users/top-builders). Directory DTO has nullable name/username, no followers/projects, and extra fields (bio, status, joinedAt)components/discover/builders-grid.tsx- Grid of BuilderCard with Pagination, including pending/error/empty statescomponents/discover/builders-view.tsx- Owns search, debounce, and page state (modelled onprojects-view.tsx)lib/api/types.ts- Fixed staleUserDirectoryItemDtocomment toBuilderListItemDtoVerification answers
StatsStripreadingpagination.totalfrom the same endpoint). UsedPaginated<BuilderListItemDto>.BuilderListItemDtowith the correct fields. No codegen was needed.