fix: guard size_t template specializations for 64-bit Unix (__LP64__)#186
Open
svenangerer wants to merge 1 commit into
Open
fix: guard size_t template specializations for 64-bit Unix (__LP64__)#186svenangerer wants to merge 1 commit into
svenangerer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the fix introduced in #183.
PR #183 successfully guarded the size_t template specializations for Windows (_WIN64) to prevent duplicate explicit template specialization errors with uint64_t. However, on 64-bit Linux, size_t and uint64_t also resolve to the same underlying type, which causes the MATLAB 2024a MEX build to fail on Ubuntu with GCC 11.4.
I have updated the preprocessor guards to #if (!defined(_WIN64) && !defined(LP64)) || defined(CUDACC) for both wrap<size_t> and unwrap<size_t> to ensure the collision is avoided on 64-bit Unix systems as well.