Mark hotspot split M2 design implemented#1124
Conversation
…to design/hotspot-split-m2-store-export # Conflicts: # kv/shard_key.go
…port' into design/hotspot-split-m2-cross-group # Conflicts: # kv/fsm.go # kv/shard_store.go # kv/shard_store_test.go # kv/sharded_coordinator.go # store/lsm_store_applied_index_test.go
…port' into design/hotspot-split-m2-cross-group # Conflicts: # kv/shard_store.go
…port' into design/hotspot-split-m2-cross-group
…oup' into design/hotspot-split-m2-promotion-complete # Conflicts: # kv/shard_store.go # kv/sharded_coordinator.go # main.go # store/store.go
…n-complete' into design/hotspot-split-m2-runner
## Summary - Complete the Milestone 2 split migration lifecycle from PLANNED through BACKFILL, FENCE, DELTA_COPY, CUTOVER, CLEANUP, DONE, and pre-cutover ABANDON. - Require durable per-voter source/target barriers, including membership changes, source-issued snapshot and fence timestamps, cutover read fencing, cleanup proofs, and bounded job history. - Add bounded physical cleanup for source and abandoned target data, plus metadata cleanup and promotion completion proofs. - Add split CLI job inspection/abandon operations and a Jepsen split workload with concurrent left/right register traffic, migration polling, faults, and FENCE abandonment coverage. ## Safety - The source write tracker and no-prune retention pin are applied and acknowledged by every current source voter before the snapshot timestamp is selected. - Snapshot and fence timestamps are issued by the source group after a linearizable leader check and are strictly greater than its last committed timestamp. - CUTOVER waits for target readiness and source read-fence acknowledgements from every current voter; membership or address changes reopen the barrier. - CLEANUP waits for descriptor visibility, read-drain grace, bounded physical deletion, and per-voter metadata absence before marking the job complete. ## Validation ### Go Test Results
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review Current head db933c0 promotes the completed hotspot split M2 central subsystem to implemented status. Evidence:
Please review the latest head. Earlier #1096 findings are stale and resolved. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several design documents to reflect that Milestone 2 (Migration Plane) of the Hotspot Shard Split has been fully implemented. The status and references have been updated from partial to implemented across the documentation. The review feedback suggests improving document navigation by converting plain-text file references into clickable Markdown links, and specifically correcting a repo-relative path that would otherwise result in a broken link.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@codex review Current signed head f270d8d addresses all current-head review findings:
All three inline findings have replies and their threads are resolved. The link target exists, the old partial path is absent, |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
28449f9 to
54cc7b9
Compare
|
@copilot resolve the merge conflicts in this pull request |
Merge conflicts resolved. The merge commit incorporates the latest base branch changes; the rename conflict was resolved by keeping the |
Summary
Evidence
lein test elastickv.split-workload-testpassed (2 tests, 5 assertions)Remaining scope