Repository navigation
Fix ligamma where tgamma(a, x) is near 1 - #1518
Merged
Merged
Conversation
For a < 2 and x < 1.1, form tgamma(a, x) - 1 from tgamma_small_upper_part's terms and take log1p, and elsewhere avoid log(value) near 1; also fix the -Wnarrowing warnings that filled the autodiff CI log. Closes #1514. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oted MSVC's long double is double, so double is evaluated in double there, and ligamma(0.1875, 0.09375) is 6 ulps off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cv9iuQnFqA3mVDEbMxNnjh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a < 2 and x < 1.1, form tgamma(a, x) - 1 from tgamma_small_upper_part's terms and take log1p, and elsewhere avoid log(value) near 1; also fix the -Wnarrowing warnings that filled the autodiff CI log. Closes #1514.
develop vs this PR, |ulps| / envelope:
🤖 Generated with Claude Code