Repository navigation
Gauss Hermite Clean Up - #1502
Conversation
|
@JacobHass8 : I am still somewhat confused as to why the |
|
Oh I see. You're trying to unify these. But could we instead have: |
In the original PR, I copied gauss_constant_category from gauss.hpp to hermite.hpp and renamed it to gauss_hermite_constant_category. Now there are to identical classes in gauss.hpp and hermite.hpp which serve as the base class. I figured get rid of the redundant code by putting it in a separate file. I kept the naming convention because all of these methods are some sort of gaussian quadrature. In thr future, if someone decides to make a different quadrature method they can include the new file in detail rather than including gauss.hpp or copying the base code. Does that make sense? Maybe I'm not explaining it well... |
That works for me! Better to not confuse with gauss methods. |
|
@JacobHass8 : Needs a rebase after the configurable top-level namespace change. |
|
@JacobHass8 : LGTM! LMK when you are ready to merge. |
I think its ready to merge! |
|
@JacobHass8 : Looks like we got some CI failures-could you investigate? |
Fixed all the issues! |
|
Merged, thanks! |
Second try with better commit history.