Skip to content

Gauss Hermite Clean Up - #1502

Merged
NAThompson merged 6 commits into
boostorg:developfrom
JacobHass8:hermite-cleanup
Oct 4, 2026
Merged

NAThompson merged 6 commits into
boostorg:developfrom
JacobHass8:hermite-cleanup

Conversation

@JacobHass8

Copy link
Copy Markdown
Contributor

Second try with better commit history.

@NAThompson

Copy link
Copy Markdown
Collaborator

@JacobHass8 : I am still somewhat confused as to why the gauss_hermite is getting renamed to gauss?

@NAThompson

NAThompson commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Oh I see. You're trying to unify these.

But could we instead have: quadrature_constant_category instead? We could also change the filename to quadrature_constant.hpp?

@JacobHass8

Copy link
Copy Markdown
Contributor Author

@JacobHass8 : I am still somewhat confused as to why the gauss_hermite is getting renamed to gauss?

In the original PR, I copied gauss_constant_category from gauss.hpp to hermite.hpp and renamed it to gauss_hermite_constant_category. Now there are to identical classes in gauss.hpp and hermite.hpp which serve as the base class. I figured get rid of the redundant code by putting it in a separate file. I kept the naming convention because all of these methods are some sort of gaussian quadrature.

In thr future, if someone decides to make a different quadrature method they can include the new file in detail rather than including gauss.hpp or copying the base code.

Does that make sense? Maybe I'm not explaining it well...

@JacobHass8

Copy link
Copy Markdown
Contributor Author

Oh I see. You're trying to unify these.

But could we instead have: quadrature_constant_category instead? We could also change the filename to quadrature_constant.hpp?

That works for me! Better to not confuse with gauss methods.

@NAThompson

Copy link
Copy Markdown
Collaborator

@JacobHass8 : Needs a rebase after the configurable top-level namespace change.

@NAThompson

Copy link
Copy Markdown
Collaborator

@JacobHass8 : LGTM! LMK when you are ready to merge.

@JacobHass8

Copy link
Copy Markdown
Contributor Author

@JacobHass8 : LGTM! LMK when you are ready to merge.

I think its ready to merge!

@NAThompson

Copy link
Copy Markdown
Collaborator

@JacobHass8 : Looks like we got some CI failures-could you investigate?

@JacobHass8

Copy link
Copy Markdown
Contributor Author

@JacobHass8 : Looks like we got some CI failures-could you investigate?

Fixed all the issues!

@NAThompson
NAThompson merged commit 56bec1a into boostorg:develop Oct 4, 2026
47 checks passed
@NAThompson

Copy link
Copy Markdown
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants