test: re-enable cmp_tribool (fixes #15) - #50
Merged
Merged
Conversation
The boostorg#15 failure was in Boost.Test's assertion_result, which could not take a tribool once its bool conversion became explicit. The suite now uses lightweight_test, whose BOOST_TEST uses a contextual bool conversion, so the test compiles and passes on gcc and clang. Also spell out the full name in the test/CMakeLists.txt copyright line.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #50 +/- ##
===========================================
+ Coverage 78.00% 81.90% +3.90%
===========================================
Files 22 22
Lines 923 923
Branches 373 373
===========================================
+ Hits 720 756 +36
+ Misses 196 160 -36
Partials 7 7 see 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@Lastique This is shouldn't be controversial and does clear an issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmp_triboolwas disabled back in 2018 (385aae0) because it didn't compile:triboolonly has an explicitoperator bool, and Boost.Test'sBOOST_CHECKneeded an implicit one.That went away in 2021 when the tests moved to Lightweight Test (53ba1b1). Its
BOOST_TESTdoes(expr) ? true : false, which works fine with an explicit conversion. The test just never got turned back on, and #49 carried the commented-out line over into CMake.So this only re-enables it in both build systems and links Boost.Logic. cmp_tribool.cpp` itself is unchanged.
Also put my full name in the CMakeLists.txt copyright line.