remove narrowing conversion in king_ordering.hpp

[Becheler]

Refs #496

Before submitting

• This PR targets the develop branch.
• I searched for an existing PR or issue covering the same change.
• My contribution is licensed under the Boost Software License 1.0.

Type of change

• Bug fix
• New feature or API addition
• Refactor (no behavior change)
• Documentation
• Build, CI, or tooling
• Other (specify below)

Does this PR introduce a breaking change?

• Yes (describe migration impact below)
• No

What this PR does

Two commits:

1. Harden king_ordering.cpp unit test (it did not assert anything) to prevent regressions
2. Convert king_ordering.hpp heap from int to std::ptrdiff_t so the size_t queue positions no longer narrow

Motivation

Refs #496

Testing

Same CI, more hardened tests, less warnings:

Job	Baseline (develop)	After fix	Δ
MSVC 14.3	1226	1154	−72
ubuntu gcc-14 (14/17/20/23)	51	51	0
ubuntu clang-19 (14/17/20/23)	75	75	0
macOS clang 14	75	75	0
macOS clang 17	70	70	0
macOS clang 20	70	70	0
all cmake jobs	0	0	0

Checklist

• Existing tests pass (b2 in the test/ directory).
• New behavior is covered by a test, or this is a docs / build / refactor change.
• Documentation was updated if user-facing behavior changed.
• No new compiler warnings on the platforms I built against.

[github-actions]

Compiler-warning counts vs develop (auto-generated).
PR run 27091112381 vs develop run 27120109824 (2dd06ac7a7).

Job	Baseline	After	Delta
macos (clang, 14)	75	75	0
macos (clang, 17)	70	70	0
macos (clang, 20)	70	70	0
ubuntu (clang-19, 14)	75	75	0
ubuntu (clang-19, 17)	75	75	0
ubuntu (clang-19, 20)	75	75	0
ubuntu (clang-19, 23)	75	75	0
ubuntu (gcc-14, 14)	51	51	0
ubuntu (gcc-14, 17)	51	51	0
ubuntu (gcc-14, 20)	51	51	0
ubuntu (gcc-14, 23)	51	51	0
windows_msvc_14_3 (msvc-14.3)	1226	1154	-72