remove narrowing conversion in random.hpp#497
Open
Becheler wants to merge 1 commit into
Open
Conversation
a5316a0 to
c1ed7ec
Compare
random.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #496
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Remove narrowing conversion in random header.
Motivation
Parameterize
uniform_inton the graph'ssize_typeto remove thesize_t>intnarrowing inrandom_vertex/random_edge, clearing the MSVC C4267 warnings and fixing latent truncation for graphs larger thanINT_MAX.Testing
Same CI, less warnings:
Checklist
b2in thetest/directory).