Repository navigation
Fix #7464: Use relative paths in generated resolved bndrun files for … - #7484
Closed
chrisrueger wants to merge 2 commits into
Closed
chrisrueger wants to merge 2 commits into
chrisrueger wants to merge 2 commits into
Conversation
…Gradle plugin This change fixes a build cache issue where the Resolve task's outputBndrun file contained absolute paths in its -include directive. These absolute paths would become stale when files were retrieved from remote build caches, causing failures in CI/CD environments. The fix generates a relative path from the output bndrun file's location to the input bndrun file. This makes the generated file portable across different machines and CI environments, and thus safe for caching. The relative path approach is also aligned with bnd's documentation which recommends using relative paths for portability.
…Maven plugin This change fixes a build cache issue where the resolver mojo's output bndrun file contained absolute paths in its -include directive. These absolute paths would become stale when files were retrieved from remote build caches, causing failures in CI/CD environments. The fix generates a relative path from the output bndrun file's location to the input bndrun file. This makes the generated file portable across different machines and CI environments, and thus safe for caching. The relative path approach is also aligned with bnd's documentation which recommends using relative paths for portability.
chrisrueger
marked this pull request as draft
October 15, 2026 09:29
bjhargrave
reviewed
Oct 15, 2026
bjhargrave
left a comment
bjhargrave
left a comment
Member
There was a problem hiding this comment.
I am not sure I would change to use relative files. For gradle I would simply annotate the output bndrun file as non-cacheable.
Contributor
Author
|
Thanks for the feedback. I come up with another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Gradle plugin
This change fixes a build cache issue where the Resolve task's outputBndrun file contained absolute paths in its -include directive. These absolute paths would become stale when files were retrieved from remote build caches, causing failures in CI/CD environments.
The fix generates a relative path from the output bndrun file's location to the input bndrun file. This makes the generated file portable across different machines and CI environments, and thus safe for caching.
The relative path approach is also aligned with bnd's documentation which recommends using relative paths for portability.
Created via AI / Copilot.
Closes #7464