Expand team and template workflows - #5198
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e10cc44ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: kenny lopez <klopez4212@gmail.com>
6e10cc4 to
6036287
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60362872fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve template channel settings during edits, retain duplicated team metadata, clear deleted section defaults, and reject oversized team mentions before provisioning. Co-authored-by: kenny lopez <klopez4212@gmail.com> Signed-off-by: kenny lopez <klopez4212@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 696e3c74c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| continue; | ||
| } | ||
|
|
||
| tags.push([TEAM_MENTION_TAG, candidate.teamId, candidate.displayName]); |
There was a problem hiding this comment.
When a locally created team has a name longer than 200 characters, this code emits the name unchanged, but parse_team_mention rejects it at event construction. The send flow creates and starts unresolved persona agents before the event builder parses these tags, so the message fails after leaving agent/channel side effects; enforce the tag constraints when naming teams or preflight the generated team tags before agent preparation.
Useful? React with 👍 / 👎.
| style={{ | ||
| minWidth: "var(--radix-dropdown-menu-trigger-width)", | ||
| }} | ||
| {form.sectionDefaultTemplateId ? ( |
There was a problem hiding this comment.
When a user opens channel creation from a templated section on a fresh session and list_channel_templates fails, sectionDefaultTemplateId remains set because reconciliation only runs after a successful query. This branch therefore replaces the picker with a locked raw template ID, yet submission still creates the channel and applyCanvas/applyAgents silently return without query data, so none of the displayed section defaults are applied; block creation with a retryable error or unlock the template selection when loading fails.
Useful? React with 👍 / 👎.
| #[tauri::command] | ||
| pub async fn pick_channel_template_project_folder(app: AppHandle) -> Result<Vec<String>, String> { |
There was a problem hiding this comment.
This new public Tauri command has no rustdoc explaining that it opens a multi-folder picker, returns an empty list on user cancellation, and can fail for invalid paths. Add a doc comment before exposing it as part of the command API.
AGENTS.md reference: AGENTS.md:L117-L117
Useful? React with 👍 / 👎.
1 participant
Summary
Testing