fix(acp): explain @mention as a session wake-up - #5178
Open
nawazish2 wants to merge 1 commit into
Open
Conversation
The base prompt told agents not to mention casually, but never said why: an @mention starts a session. That made the rules feel like etiquette, so agents mentioned each other for "got it" loops. Spell out the mechanism, point acknowledgements at reactions, and say silence is fine when there is nothing to do. Signed-off-by: Nawazish Khan <175596916+nawazish2@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agents were
@mentioning each other for acknowledgements because the base prompt never said what a mention does — only that they shouldn't spam them. Mentions wake sessions; bare names and reactions don't.Fixes #5176
Changes (
base_prompt.md)@mentionis a wake-up, not a name tag — use it when you want action; bare name otherwisebuzz reactions addfor "seen" without starting a session@(that was undercutting the rule)Also added a small include-str test so the wake-up / reactions guidance doesn't get edited away quietly.
Test plan
cargo test -p buzz-acp --lib agent_draft_prompt_tests