Fix mobile DM recipient tags - #5173
Open
Tiago-Sonar wants to merge 2 commits into
Open
Conversation
Co-authored-by: TMC <tiago@sonargtm.com> Signed-off-by: TMC <tiago@sonargtm.com>
Fail closed when channel metadata is unavailable so thread replies cannot silently omit DM participant tags. Co-authored-by: TMC <tiago@sonargtm.com> Signed-off-by: TMC <tiago@sonargtm.com>
Author
|
@block/buzz-oss-team Review requested. This critical reliability fix is mergeable; DCO, Semgrep, and zizmor are green, and the PR body records the full local validation and independent review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ptags on mobile DM messagesWhy
Mobile DM messages without an explicit
@mentionwere published without a recipientptag. Recipient-gated agent harnesses could therefore ignore a visible message, making managed agents such as Donna appear not to answer.Validation
./bin/just ciOrigin
Buzz channel:
4c0769da-da97-4e9d-bf12-152ddbaec0aaThread root:
22f9b299f0da00ce02648abdf49ff7a221cad8e68599565737817d3ed087bc1b