test(agent): wait for cancel acknowledgement - #5003
Open
kiranmagic7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
wesbillman
approved these changes
Aug 6, 2026
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
Awesome, thanks for this!
wesbillman
enabled auto-merge (squash)
August 6, 2026 03:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wait for the
session/cancelacknowledgement before releasing the gated round-two LLM response, then include frames received before that acknowledgement in the existing ordering assertions.Writing the cancel request to stdin did not prove the agent had processed it. The test could therefore release the deliberate error response first and observe a null
stopReasoninstead ofcancelled.Related issue
Fixes #4945. No duplicate issue or PR was found in the current open or historical searches.
Testing
main: the affected test failed in 16 of 100 fullfake_llmsuite runs.bin/cargo test -p buzz-agent --test fake_llm cancelled_turn_with_usage_emits_notification_before_response -- --exactbin/cargo test -p buzz-agentbin/just ci