Repository navigation
Move the anti-bot rules into antibot_rules.json, and stop counting Imperva's loader as a challenge - #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protection classifier's vendor rules were hard-coded in
src/antibot.rs, so fixing a false positive meant a rebuild and a release. They now live inantibot_rules.json, and the code only runs them.Rules as data
antibot_rules.jsonholds an ordered list of rules: a vendor, an outcome (challenge,blocked,present), an optionalon_refusaloutcome, and awhencondition built fromstatus,header_present,header_contains,cookie_set,cookie_prefixandbody_contains, combined withall,anyandnot. The first match wins, as before. Rules keep their reasoning in an optionalwhyfield, since JSON has no comments.blasthttp.set_antibot_rules(path)(antibot::set_rulesin Rust) replaces the rules for the process at runtime, andset_antibot_rules()restores the built-in ones. A malformed file is refused when it loads.Vendoris now a name rather than an enum, so a rules file can add a product. Python callers already received vendors as strings and are unaffected.Imperva
_Incapsula_Resourceanywhere in a body counted as a challenge. Imperva appends its loader script (_Incapsula_Resource?SWJIYLWA=…&ns=1&cb=…) to pages it let through, including the origin's own error pages, so ordinary pages were judgedneeds_browserand sent to a browser that had nothing to solve. A challenge now needs Imperva's incident page (_Incapsula_Resource?CWUDNSAI=), or a reference to the resource that isn't the loader.