chore(deps): require hooks 2 - #141
Johnosezele wants to merge 3 commits into
Conversation
native_toolchain_rust 1.0.7 needs hooks 2, and the ^1.0.0 constraint blocks any app already on hooks 2. Raise it before 1.0.0 so this is not a breaking change after stable.
|
Are we intentionally dropping Flutter 3.38 support? flutter pub get works on the base branch but fails on this PR because Flutter pins meta 1.17.0 and the new hooks dependency requires meta 1.19.0. And then I published 1.0.0 so we just need to tweak the changelog saying rc4 |
Not as the goal. This PR raises hooks to ^2.1.0, and that floor cannot resolve on Flutter 3.38.
flutter pub get fails because hooks 2.1 or newer pulls record_use 1, which needs meta 1.19.0 or newer. Flutter 3.38's package:flutter depends on meta: 1.17.0 exactly, so it stays on 1.17.0. The base branch is still on hooks 1, which allows that. |
Great! |
Thanks, that confirms the cause. Can we try those lower bounds and test Flutter 3.38 before deciding to drop support? If we do intend to drop it, should we state that explicitly and put the changelog entry? |
Lower the floors to hooks ^2.0.2 and native_toolchain_rust ^1.0.4. Those still allow the latest releases, and Flutter 3.38 can stop at hooks 2.0.2 and native_toolchain_rust 1.0.4+0 instead of requiring meta 1.19.
|
@reez I've lower them to hooks: ^2.0.2 and native_toolchain_rust: ^1.0.4, these still work fine with Flutter 3.38 |
Summary
hooksto^2.1.0andnative_toolchain_rustto^1.0.7so apps already on hooks 2 can depend on this package.code_assetsdev dependency to^2.0.0, whichnative_toolchain_rust1.0.7 requires.hook/build.dartunchanged. It only callsbuildandRustBuilder.Without this any app already on hooks 2 cannot depend on this package. Apps still on hooks 1 can no longer depend on this package. This also improves pub.dev score, as is a requirement
closes #137
Test
dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overridesshowshooks2.2.0 andnative_toolchain_rust1.0.7 as current and latestdart analyzeis clean