fix: detect the dual license and expand the pub.dev description - #139
Johnosezele wants to merge 5 commits into
Conversation
Pana only scores the file named LICENSE. The previous pointer was detected as an unknown license.
|
General idea of upping our score is good, but our current LICENSE matches upstream bdk, bdk_wallet, and bdk-ffi, including “Some files retain their own copyright notice” and “Except as otherwise noted in individual files”, but this rewrite drops those clauses. |
|
I shall add them, thanks for pointing it out. |
…hile adding the sections for APACHE and MIT so that pub.dev can recognize license as valid
… fix/license-pana-detection
It will also improve the library credibility as an official one.
true, the problem lies here because the underlying check for pub.dev checks for only LICENSE and expects to find a valid MIT or APACHE one in there, but since we have it in separate files, its not able to recognize. @reez I've inlined the two full license texts into LICENSE, plus the required wordings from upstream LICENSE. |
Summary
LICENSE. Pana only scores that filename, and the old pointer was detected as an unknown license.LICENSE-MITandLICENSE-APACHEare unchanged.pubspec.yamldescription to 110 characters so it says this is for Dart and Flutter descriptor wallets. Pana wants 50–180 characters.Test
LICENSEis still MIT OR Apache-2.0, with both full texts in that file