Mark the error-handling entry done in potential_improvements.md - #479
Open
KillerX wants to merge 1 commit into
Open
Mark the error-handling entry done in potential_improvements.md#479KillerX wants to merge 1 commit into
KillerX wants to merge 1 commit into
Conversation
#478 landed the code without updating the ledger, which is the failure mode this file already has. Records what was done, what stayed (merry as an indirect dependency, the zero string-matched comparisons), and the one part deliberately skipped. Also drops the vx_export_vod errs loop from Awkward constructs — it is errors.Join on master already. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#478 landed the code without updating
potential_improvements.md, which is exactly the "good inbox, poor ledger" failure the file already has. This records what was done (merry removed,%weverywhere there is a cause,errors.Join, the logger call shape, the convention written intoCLAUDE.md), what stayed (merry as an indirect dependency of bcc-media-platform; zero string-matched error comparisons), and the one part deliberately skipped (the ~50 argument-lessfmt.Errorfcalls that could beerrors.New— no linter flags them and the rewrite changes no behaviour).Also drops the
for _, err = range service.errsline from Awkward constructs:vx_export_vod.gouseserrors.Joinon master already.Docs only — no code changes.
🤖 Generated with Claude Code