Skip to content

fix(pip): parse the index_url from uv.lock file#3906

Merged
rickeylev merged 4 commits into
bazel-contrib:mainfrom
aignas:aignas.fix.uv_lock_index_url
Jul 9, 2026
Merged

fix(pip): parse the index_url from uv.lock file#3906
rickeylev merged 4 commits into
bazel-contrib:mainfrom
aignas:aignas.fix.uv_lock_index_url

Conversation

@aignas

@aignas aignas commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

This is so that the purl can be generated correctly and we
pass the right index_url parameter to the whl_library file.

Work towards #1975

This is so that the purl can be generated correctly and we
pass the right index_url parameter to the whl_library file.

Work towards bazel-contrib#1975
@aignas aignas requested a review from rickeylev as a code owner July 6, 2026 13:59

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the uv.lock JSON parser to extract and populate the index_url for packages, and updates the corresponding tests to reflect this change. The reviewer identified potential issues with the current implementation, including a double-slash bug when the registry URL has a trailing slash, failure to resolve custom registries that do not end with 'simple', and potential runtime errors if source or registry is None. A code suggestion was provided to address these concerns.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread python/private/pypi/parse_requirements.bzl Outdated
aignas and others added 2 commits July 6, 2026 23:00
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rickeylev rickeylev enabled auto-merge July 9, 2026 02:04
@rickeylev rickeylev added this pull request to the merge queue Jul 9, 2026
Merged via the queue into bazel-contrib:main with commit 00922ad Jul 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants