Add explicit flexbox spec-compliance gap tests - #19
basvanmeurs with Copilot wants to merge 7 commits into
Conversation
Co-authored-by: basvanmeurs <120531+basvanmeurs@users.noreply.github.com>
|
@copilot what is the flex-shrink problem? Onky the default value? |
In this PR, yes—the |
|
@copilot please implement order and flexBasis, and fix the flexShrink default. Run tests. You may have to fix other unit tests. |
Co-authored-by: basvanmeurs <120531+basvanmeurs@users.noreply.github.com>
Co-authored-by: basvanmeurs <120531+basvanmeurs@users.noreply.github.com>
Implemented in commits Changes now include:
Validation run:
|
|
Hey @copilot there's still a todo!! Fix/implement as well and remove todo. Or is that undoable? In that case remove the comment |
Co-authored-by: basvanmeurs <120531+basvanmeurs@users.noreply.github.com>
Done in |
|
@copilot can you make sure that the changes are really all valud according to flexbox specs? Please prove it |
Co-authored-by: basvanmeurs <120531+basvanmeurs@users.noreply.github.com>
I added extra spec-focused tests in |
|
@copilot create that WPT matrix. You may add tests but dont change anything |
Co-authored-by: basvanmeurs <120531+basvanmeurs@users.noreply.github.com>
Implemented in I added a WPT-style matrix in
Validation run: |
This PR addresses the spec-correctness question by codifying current behavior where
flexbox.jsdiverges from CSS Flexbox. It adds characterization tests only; layout engine behavior is intentionally unchanged.New coverage: spec-compliance gaps
tests/test.spec-compliance.tswith focused cases documenting current non-spec behavior.flex-shrink: 1behavior.flexItem.orderis ignored (source order is retained).flexItem.flexBasisis ignored (width/height continue to drive basis).Intent of these tests
Example (from new tests)