fix(ai-gateway): drop the Base44-App-Base-Url header path#222
Merged
Conversation
connection() now always builds the gateway baseURL from serverUrl (Base44-Api-Url inside backend functions). The backend PR that injected Base44-App-Base-Url was closed, so the header never ships; the platform instead guarantees Base44-Api-Url resolves to the app on every invocation path. Removes the header read in createClientFromRequest, the appBaseUrl plumbing into the AI gateway module, and the related tests. The pre-existing appBaseUrl client config (auth login/logout URLs) is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.35-pr.222.127e5f6Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.35-pr.222.127e5f6"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.35-pr.222.127e5f6"
}
}
Preview published to npm registry — try new features instantly! |
yardend-wix
changed the title
netanelgilad
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
Base44-App-Base-Urlmechanism introduced in #214, before any release ships it (aiGatewayis still unpublished — latest npm is 0.8.35):createClientFromRequestno longer reads theBase44-App-Base-UrlheaderappBaseUrl;connection()builds itsbaseURLfromserverUrlonly (i.e.Base44-Api-Urlinside backend functions)appBaseUrl-preference tests; kept coverage for building fromBase44-Api-UrlThe pre-existing
appBaseUrlclient-config option (auth login/logout redirect URLs) is untouched.Why
The apper PR that would have injected
Base44-App-Base-Urlinto function invocations (base44-dev/apper#14868) was closed — the header will never exist on real invocations, so the SDK reading it is dead code.Verified live instead that
Base44-Api-Urlalready resolves to an app-recognized domain on the invocation paths that matter — published app traffic (same-origin), sandbox editor preview (preview-sandbox--{app_id}.*hosts are domain-resolved), and background workflows/automations (app-domain fallback) — soserverUrlis the right gateway origin. The one remaining gap (the builder's in-process test-function tool passes the builder host) is being fixed on the platform side, not in the SDK.Tests
npm test: 177 passed.tsc --noEmitclean.🤖 Generated with Claude Code