Add specification review checklist (Type 3)#403
Open
nebeid wants to merge 1 commit intoawslabs:mainfrom
Open
Conversation
Fill in the previously empty "Type 3: Adding a New Specification" section based on John Harrison's presentation on formal specification style and validation (2026-04-08 team meeting). Key additions: - Prefer abstract mathematical specs over code-like pseudocode - Support layered specifications (low/medium/high level) - Validation guidance for "gap A" (spec vs intended behavior) - Executability and standards-document traceability checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills in the empty "Type 3: Adding a New Specification" section of the PR review checklist based on John Harrison's presentation on formal specification style and validation (2026-04-08 team meeting).
The meeting discussed how specifications for non-mathematical functions (AES, SHA) carry higher risk of spec bugs than clean mathematical specs (bignum arithmetic, elliptic curves). The checklist now reflects this distinction and provides concrete validation steps for each case.
Changes
Adds checklist items covering: