Skip to content

[BuildImage] Support build-image with UpdateOs=Enabled in proxied environments - #7605

Open
gmarciani wants to merge 3 commits into
aws:developfrom
gmarciani:wip/mgiacomo/3170/fix-build-updateos-nointernet-0903-1
Open

[BuildImage] Support build-image with UpdateOs=Enabled in proxied environments#7605
gmarciani wants to merge 3 commits into
aws:developfrom
gmarciani:wip/mgiacomo/3170/fix-build-updateos-nointernet-0903-1

Conversation

@gmarciani

@gmarciani gmarciani commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Support build-image with UpdateOs enabled in proxied environments.

With this fix we now execute the proxy configuration in the ImageBuilder component update_and_reboot.yaml.
The proxy config steps mimic what we already do in the dedicated cookbook recipe.

Alternative approaches

As an alternative approach we could invoke the cookbook recipe to setup the proxy. In this way we would have the logic to configure the proxy in a single place. However, I am not doing it here because this would break the following two rules we have always complied with:

  1. update&reboot component must not depend on any cookbook artifact. This rule can be revised b/c
  2. we do not call internal recipes. this is a weak argument b/c we could anyways create a new entrypoint just to configure the proxy.

Tests

ONGOING

test-suites:
  createami:
    test_createami.py::test_build_image_no_internet:
      dimensions:
        # RHEL family (rhel8, rhel9) -> Red Hat Enterprise Linux reservation platform
        - regions: [{{ g4dn_2xlarge_CAPACITY_RESERVATION_2_INSTANCES_3_HOURS_NOPG_rhel9 }}]
          instances: ["g4dn.2xlarge"]
          oss: ["rhel8", "rhel9"]
        # Non-RHEL family (alinux2023, ubuntu2204, ubuntu2404, rocky8, rocky9) -> Linux/UNIX reservation platform
        - regions: [{{ g4dn_2xlarge_CAPACITY_RESERVATION_5_INSTANCES_3_HOURS_NOPG_ubuntu2404 }}]
          instances: ["g4dn.2xlarge"]
          oss: ["alinux2023", "ubuntu2204", "ubuntu2404", "rocky8", "rocky9"]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani added 3.x skip-bad-url-suffix-check Skip the checks regarding the bad URL suffix labels Sep 3, 2026
@gmarciani gmarciani changed the title Wip/mgiacomo/3170/fix build updateos nointernet 0903 1 [BuildImage] Support build-image with UpdateOs enabled in proxied environments Sep 4, 2026
@gmarciani gmarciani changed the title [BuildImage] Support build-image with UpdateOs enabled in proxied environments [BuildImage] Support build-image with UpdateOs=Enabled in proxied environments Sep 8, 2026
@gmarciani
gmarciani force-pushed the wip/mgiacomo/3170/fix-build-updateos-nointernet-0903-1 branch 3 times, most recently from 74cb7cb to 1bc53a0 Compare September 8, 2026 17:05
To this aim we needed to execute the proxy configuration in the ImageBuilder component update_and_reboot.yaml.
The proxy config steps mimic what we already do in the dedicated cookbook recipe.
…he test honor the flag to enable/disable OS updates.

The test will now follow the same configuration used by the unproxied test test_build_image.
@gmarciani
gmarciani force-pushed the wip/mgiacomo/3170/fix-build-updateos-nointernet-0903-1 branch from 2272306 to c15f1f7 Compare September 8, 2026 19:30
@gmarciani
gmarciani marked this pull request as ready for review September 8, 2026 22:10
@gmarciani
gmarciani requested review from a team as code owners September 8, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-bad-url-suffix-check Skip the checks regarding the bad URL suffix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant