fix: re-enable type checking#471
Merged
Merged
Conversation
zhongkechen
force-pushed
the
type_checking
branch
2 times, most recently
from
4015c19 to
19199d8
Compare
zhongkechen
force-pushed
the
type_checking
branch
from
19199d8 to
340793b
Compare
Contributor
|
good catch, the output from the Github action is not visible at all locally actually so I completely missed this |
SilanHe
reviewed
Jun 11, 2026
| workspace.members = ["packages/*"] | ||
|
|
||
| [tool.hatch.envs.test] | ||
| detached = true |
Contributor
There was a problem hiding this comment.
interesting, I didn't know about this setting.
In this case, I guess we could technically add this for all envs in the pyproject.toml?
SilanHe
approved these changes
Jun 11, 2026
wangyb-A
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix: #469
Description of changes:
Type checking is not working after we migrated to monorepo and the ci workflow succeeded with the type checker actually failing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.