Skip to content

chore: release fails because of runtime dependency on private packages - #1776

Merged
aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore-fix-tool-usage
Jul 29, 2026
Merged

chore: release fails because of runtime dependency on private packages#1776
aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore-fix-tool-usage

Conversation

@mrgrain

@mrgrain mrgrain commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #

aws-cdk's bundled-only packages (@aws-cdk/private-tools, @aws-cdk/cdk-explorer) were declared as runtime dependencies, so they stay pinned at projen's ^0.0.0 placeholder (they're never published). gather-versions in cdklabs-projen-project-types now fails releases loudly on any 0.0.0 runtime/peer dependency (cdklabs/cdklabs-projen-project-types#960), breaking our release: https://github.com/aws/aws-cdk-cli/actions/runs/30441825065/job/90542709045

Moves both packages to devDependencies instead, since they're inlined by the bundler and not needed as real runtime deps.

Checklist

  • This change contains a major version upgrade for a dependency and I confirm all breaking changes are addressed
    • Release notes for the new version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@aws-cdk/cdk-explorer ^0.0.0 UnknownUnknown
npm/@aws-cdk/private-tools ^0.0.0 UnknownUnknown
npm/esbuild ^0.28.1 UnknownUnknown

Scanned Files

  • packages/aws-cdk/package.json

@mrgrain mrgrain changed the title chore: move private methods into devDeps fix(aws-cdk): release fails when bundled private packages resolve to 0.0.0 Jul 29, 2026
@mrgrain mrgrain changed the title fix(aws-cdk): release fails when bundled private packages resolve to 0.0.0 chore: release fails because of prod dependency on private packages Jul 29, 2026
@mrgrain mrgrain changed the title chore: release fails because of prod dependency on private packages chore: release fails because of runtime dependency on private packages Jul 29, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (957c309) to head (c11b848).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1776   +/-   ##
=======================================
  Coverage   90.05%   90.06%           
=======================================
  Files          78       80    +2     
  Lines       12110    12117    +7     
  Branches     1698     1699    +1     
=======================================
+ Hits        10906    10913    +7     
  Misses       1175     1175           
  Partials       29       29           
Flag Coverage Δ
suite.unit 90.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
aws-cdk-automation added this pull request to the merge queue Jul 29, 2026
Merged via the queue into main with commit d87457e Jul 29, 2026
65 of 66 checks passed
@aws-cdk-automation
aws-cdk-automation deleted the mrgrain/chore-fix-tool-usage branch July 29, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants