chore: revert "refactor: migrate all subprocess call sites to the shared subprocess module" - #1774
Merged
Conversation
…process …" This reverts commit e8aaa6b.
aws-cdk-automation
enabled auto-merge
July 29, 2026 15:09
Contributor
Dependency ReviewThe following issues were found:
License Issuespackages/@aws-cdk/toolkit-lib/package.json
OpenSSF Scorecard
Scanned Files
|
iankhou
approved these changes
Jul 29, 2026
iankhou
left a comment
Contributor
There was a problem hiding this comment.
The world wasn't ready for this change
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1774 +/- ##
=======================================
Coverage 90.03% 90.04%
=======================================
Files 78 78
Lines 12035 12110 +75
Branches 1685 1698 +13
=======================================
+ Hits 10836 10904 +68
- Misses 1169 1177 +8
+ Partials 30 29 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1758
We decided this is too risky right now since we don't have windows integration tests as part of the release flow. We will prioritize the Windows integ tests first.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license