Skip to content

chore: revert "refactor: migrate all subprocess call sites to the shared subprocess module" - #1774

Merged
aws-cdk-automation merged 1 commit into
mainfrom
revert-1758-iankhou-shell-interactions
Jul 29, 2026
Merged

chore: revert "refactor: migrate all subprocess call sites to the shared subprocess module"#1774
aws-cdk-automation merged 1 commit into
mainfrom
revert-1758-iankhou-shell-interactions

Conversation

@mrgrain

@mrgrain mrgrain commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Reverts #1758

We decided this is too risky right now since we don't have windows integration tests as part of the release flow. We will prioritize the Windows integ tests first.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
aws-cdk-automation requested a review from a team July 29, 2026 15:09
@github-actions github-actions Bot added the p2 label Jul 29, 2026
@mrgrain mrgrain changed the title Revert "refactor: migrate all subprocess call sites to the shared subprocess module" chore: revert "refactor: migrate all subprocess call sites to the shared subprocess module" Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

packages/@aws-cdk/toolkit-lib/package.json

PackageVersionLicenseIssue Type
split2^4.2.0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@types/split2 ^4.2.3 UnknownUnknown
npm/split2 ^4.2.0 UnknownUnknown
npm/@types/split2 4.2.3 🟢 6.5
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 4 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 8Found 24/30 approved changesets -- score normalized to 8
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
npm/split2 4.2.0 🟢 4.7
Details
CheckScoreReason
Maintained⚠️ 01 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Code-Review🟢 3Found 8/22 approved changesets -- score normalized to 3
Binary-Artifacts🟢 10no binaries found in the repo
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Security-Policy🟢 10security policy file detected
Token-Permissions🟢 9detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Signed-Releases⚠️ -1no releases found
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • packages/@aws-cdk/cdk-assets-lib/package.json
  • packages/@aws-cdk/toolkit-lib/package.json
  • yarn.lock

@iankhou iankhou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The world wasn't ready for this change

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.56522% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.04%. Comparing base (e8aaa6b) to head (1809d3c).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/commands/init/os.ts 85.88% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1774   +/-   ##
=======================================
  Coverage   90.03%   90.04%           
=======================================
  Files          78       78           
  Lines       12035    12110   +75     
  Branches     1685     1698   +13     
=======================================
+ Hits        10836    10904   +68     
- Misses       1169     1177    +8     
+ Partials       30       29    -1     
Flag Coverage Δ
suite.unit 90.04% <89.56%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
aws-cdk-automation added this pull request to the merge queue Jul 29, 2026
Merged via the queue into main with commit 957c309 Jul 29, 2026
57 of 62 checks passed
@aws-cdk-automation
aws-cdk-automation deleted the revert-1758-iankhou-shell-interactions branch July 29, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants