fix(lock): release the lock files that were actually taken - #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initLockFile()only flagged the deployment as holding a lock after every serverhad been visited:
With several servers, if a later one is already locked, the exception leaves the
earlier servers with a lock file that
clearLockFile()then refuses to remove. Thoseservers stay locked forever: every subsequent deployment fails with "A deployment is
already in progress" until someone passes
--forceor deletes the file by hand.Locks are now recorded server by server, as soon as they are taken, and released the
same way — a server locked by another deployment is left untouched.
Tests
New
LockListenerTest, 3 cases. The one covering the orphan lock fails onmain.