fix(session): chain the working directory with && instead of ; - #78
Merged
Merged
Conversation
Member
|
Thank @loicsapone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands were sent as:
;runs the second command whatever happened to the first. When the release directoryis missing — a cleanup that ran concurrently, a release moved to
releases/failedafter an earlier failure — the
cdfails but the command still runs, from the homedirectory of the SSH user. A hook such as
rm -rf var/cachethen hits the wrong tree.Both
exec()andexecAsync()now use&&.Tests
Existing assertions updated, plus a case covering
execAsync()with a workingdirectory, which had the same bug and no coverage.
Note
The paths themselves are still interpolated unquoted, here and in
mkdir/mv/rm/symlink/touch. Escaping them is a consistent change of its ownand is deliberately left out of this PR.