Fix parsing of UserUpdatedEvents#896
Open
pvancoeverden wants to merge 1 commit into
Open
Conversation
354a4ab to
566834a
Compare
When I subscribed to UserUpdateEvents, all events are of the type: `EventStreamSubscribeEventsResponseContent._UnknownValue, without readable data. This commit fixes this. Added a EventsSubscribeSseTest wich shows the original problem.
566834a to
479df9e
Compare
5 tasks
Author
|
Fixes #897 |
Author
|
I realize now that some code is generated with Fern. But this project has no information how it is generated. I think it is better to fiddle with the api-spec and/or fern configuration to fix this bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When I subscribed to UserUpdateEvents, all events are of the type:
EventStreamSubscribeEventsResponseContent._UnknownValue, without readable data. This commit fixes this. Added a EventsSubscribeSseTest that shows the original problem.References
Example code to reproduce the bug:
All events will print
Received unknown Auth0 event type, ignoring: EventStreamSubscribeEventsResponseContent{type: null, value: null}This is because the response is not parsed correctly: the
valueof all events are of type'_Unkowninstead of the correct valueI've added the EventsSubscribeSseTest wich mimics the example code.
Please include relevant links supporting this change:
_UnknownValue#897Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Tested with java 21 in our own project, and build the unit-tests with java 17 because spotless did not work with my later java versions. (com.sun libs missing)
Checklist