Skip to content

Use data-syncscroll instead of name #3

Description

@jenstornell

Are you still maintaining this thing? I had a PHP form that already had name taken. It's not good for syncscroll to use something that is already used by the form.

Around line 51, I change to this:

if (!(name = el.dataset.syncscroll)) {

Other than that it's working great!

By the way, I also changed line 33:

var elems = document.querySelectorAll('[data-syncscroll]');

That way the class does not need to be set.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions