Skip to content

1D wavelength solution ASDF export/import - #317

Merged
hpparvi merged 5 commits into
astropy:mainfrom
hpparvi:asdf_serialization
Sep 3, 2026
Merged

1D wavelength solution ASDF export/import#317
hpparvi merged 5 commits into
astropy:mainfrom
hpparvi:asdf_serialization

Conversation

@hpparvi

@hpparvi hpparvi commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This PR adds the WavelengthSolution1D.to_asdf and WavelengthSolution1D.from_asdf methods to serialize a 1D wavelength solution into an ASDF file.

AI/LLM disclaimer: similarly to #316, I used Claude Fable to speed up the development.

…sdf` methods to serialise a 1D wavelength solution into an ASDF file.
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.35%. Comparing base (0d2ce22) to head (70c26d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   92.25%   92.35%   +0.10%     
==========================================
  Files          18       18              
  Lines        2234     2264      +30     
==========================================
+ Hits         2061     2091      +30     
  Misses        173      173              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tepickering

Copy link
Copy Markdown
Contributor

i will give this a more thorough review later this week. the python 3.11 and RTD failures should be looked into. i would argue that we can drop 3.11 at this point.

@hpparvi

hpparvi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, @tepickering! I've fixed the RDT issues and dropped support for Python 3.11.

@tepickering tepickering left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GWCS and ASDF are the way forward. need to get the rest of the community to come along...

@hpparvi
hpparvi merged commit 5331a47 into astropy:main Sep 3, 2026
15 of 16 checks passed
@hpparvi
hpparvi deleted the asdf_serialization branch September 3, 2026 15:30
@tepickering

Copy link
Copy Markdown
Contributor

looks like we missed pruning the python 3.11 test from the CI so it's failing. good timing on dropping it, though, because astropy will drop it as well as of v8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants