1D wavelength solution ASDF export/import - #317
Conversation
…sdf` methods to serialise a 1D wavelength solution into an ASDF file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 92.25% 92.35% +0.10%
==========================================
Files 18 18
Lines 2234 2264 +30
==========================================
+ Hits 2061 2091 +30
Misses 173 173 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
i will give this a more thorough review later this week. the python 3.11 and RTD failures should be looked into. i would argue that we can drop 3.11 at this point. |
- Fixed `WavelengthSolution1D.to_asdf` docstring.
4212b74 to
db75c64
Compare
|
Thanks, @tepickering! I've fixed the RDT issues and dropped support for Python 3.11. |
tepickering
left a comment
There was a problem hiding this comment.
GWCS and ASDF are the way forward. need to get the rest of the community to come along...
|
looks like we missed pruning the python 3.11 test from the CI so it's failing. good timing on dropping it, though, because astropy will drop it as well as of v8.1. |
This PR adds the
WavelengthSolution1D.to_asdfandWavelengthSolution1D.from_asdfmethods to serialize a 1D wavelength solution into an ASDF file.AI/LLM disclaimer: similarly to #316, I used Claude Fable to speed up the development.