Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 15-digit OGRNIP numbers, the check digit is the last decimal digit of the remainder modulo 13. The current calculation returns two characters when the remainder is 10, 11 or 12, rejecting numbers whose final digit is correctly 0, 1 or 2.
Apply the final modulo 10, as the 13-digit OGRN branch already does. Add regression coverage for all three affected remainders, validation of those numbers, and rejection of incorrect check digits. Also correct the OGRNIP test section's length label.
Fixes #516.
Validation: the new doctest fails on the original implementation (
['10', '11', '12']instead of['0', '1', '2']). The complete suite passes with the fix: 413 passed, 9 skipped, 100% statement and branch coverage. Scoped flake8 passes.