Skip to content

Fix OGRNIP check digits for two-digit remainders - #517

Open
natesute wants to merge 1 commit into
arthurdejong:masterfrom
natesute:fix/ogrnip-check-digit
Open

natesute wants to merge 1 commit into
arthurdejong:masterfrom
natesute:fix/ogrnip-check-digit

Conversation

@natesute

Copy link
Copy Markdown

For 15-digit OGRNIP numbers, the check digit is the last decimal digit of the remainder modulo 13. The current calculation returns two characters when the remainder is 10, 11 or 12, rejecting numbers whose final digit is correctly 0, 1 or 2.

Apply the final modulo 10, as the 13-digit OGRN branch already does. Add regression coverage for all three affected remainders, validation of those numbers, and rejection of incorrect check digits. Also correct the OGRNIP test section's length label.

Fixes #516.

Validation: the new doctest fails on the original implementation (['10', '11', '12'] instead of ['0', '1', '2']). The complete suite passes with the fix: 413 passed, 9 skipped, 100% statement and branch coverage. Scoped flake8 passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ru.ogrn: 15-digit (OGRNIP) check digit is missing the final % 10, so about 23% of valid numbers are rejected

1 participant