remove performix from MCP Server and documentation in this repo - #164
Open
JoeStech wants to merge 1 commit into
Open
remove performix from MCP Server and documentation in this repo#164JoeStech wants to merge 1 commit into
JoeStech wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the bundled Arm Performix/APX runtime and its apx_recipe_run MCP tool from the server, build artifacts, CI, and in-repo documentation, and updates “performance” guidance to route users through knowledge_base_search and an external/dedicated Performix MCP server (with Linux perf as fallback).
Changes:
- Removed Performix/APX runtime packaging, lock entries, staging logic, integration tests, and SSH/target setup from CI.
- Removed the
apx_recipe_runtool implementation and associated SQL/query/test assets; updated server metadata and docs accordingly. - Updated agent prompt templates to start with
knowledge_base_search, then use a dedicated Performix MCP server (orperffallback).
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes Performix-related docs and SSH volume-mount examples. |
| mcp-local/utils/apx.py | Deletes APX/Performix helper utilities (tool implementation support). |
| mcp-local/tests/test_mcp.py | Removes APX integration coverage; adds assertion that APX tool is absent and KB routing hint exists. |
| mcp-local/tests/test_build_inputs.py | Drops Performix lock/assertions; adds tests ensuring Performix is not bundled and prompts are updated. |
| mcp-local/tests/CpuBurnerOriginal.java | Removes Performix/APX integration-test workload source. |
| mcp-local/tests/constants.py | Removes APX tool call request fixtures. |
| mcp-local/sql/queries.sql | Deletes Performix/APX recipe SQL queries. |
| mcp-local/server.py | Removes apx_recipe_run tool and APX imports; updates knowledge_base_search description with performance-routing hint. |
| mcp-local/server.json | Removes SSH-key/known_hosts runtime argument templates (Performix-specific). |
| mcp-local/scripts/stage-build-inputs.py | Removes Performix artifact staging step. |
| mcp-local/performix-deployment-scenarios.md | Removes Performix/APX usage guide. |
| mcp-local/Dockerfile.inputs | Removes Performix artifact from inputs image layout. |
| mcp-local/Dockerfile | Removes Performix extraction, env vars, and runtime wiring; removes SQL copy that was only used for APX queries. |
| mcp-local/build-inputs.lock.json | Removes Performix artifacts from the lock. |
| CONTRIBUTING.md | Updates reproducible-build documentation to remove Performix references. |
| agent-integrations/windsurf/arm-vs-x86-performance-comparison.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/windsurf/arm-hotspots-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/windsurf/arm-full-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/vs-code/arm-vs-x86-performance-comparison.prompt.md | Removes apx_recipe_run tool; updates instructions to dedicated Performix MCP server workflow. |
| agent-integrations/vs-code/arm-hotspots-optimization.prompt.md | Removes apx_recipe_run tool; updates instructions to dedicated Performix MCP server workflow. |
| agent-integrations/vs-code/arm-full-optimization.prompt.md | Removes apx_recipe_run tool; updates instructions to dedicated Performix MCP server workflow. |
| agent-integrations/vs-code/arm-enablement.prompt.md | Removes apx_recipe_run from tool list; updates optional perf evidence guidance to dedicated Performix MCP server. |
| agent-integrations/kiro/arm-vs-x86-performance-comparison.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/kiro/arm-hotspots-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/kiro/arm-full-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/gemini/arm-vs-x86-performance-comparison.toml | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/gemini/arm-hotspots-optimization.toml | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/gemini/arm-full-optimization.toml | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/cursor/arm-vs-x86-performance-comparison.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/cursor/arm-hotspots-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/cursor/arm-full-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/codex/arm-vs-x86-performance-comparison.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/codex/arm-hotspots-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/codex/arm-full-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/codex/arm-enablement/SKILL.md | Updates expected Arm MCP tool availability and performance-evidence guidance. |
| agent-integrations/antigravity/arm-vs-x86-performance-comparison.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/antigravity/arm-hotspots-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/antigravity/arm-full-optimization.md | Routes performance workflow via knowledge search + dedicated Performix MCP server / perf fallback. |
| agent-integrations/agent-install-instructions.md | Removes Performix/SSH mount instructions from installation guide. |
| .github/workflows/integration-tests.yml | Removes SSH target + Java workload setup and APX debug env from CI integration tests. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| in knowledge_search["description"] | ||
| ) | ||
|
|
||
| print("\n***Test Passed: arm-mcp container initilized and ran successfully") |
Comment on lines
32
to
+33
| The final MCP image build does not resolve or download Python packages, Ubuntu | ||
| packages, Performix, or migrate-ease. Those inputs are acquired separately by | ||
| packages or migrate-ease. Those inputs are acquired separately by |
Comment on lines
+265
to
+269
| #### Updating Migrate-ease | ||
|
|
||
| Update the versioned URL or source revision and the expected SHA256 in | ||
| `mcp-local/build-inputs.lock.json`. Prefer an upstream-published checksum when | ||
| one is available. Performix has separate AMD64 and Arm64 artifacts; | ||
| migrate-ease is one pinned source archive used by both architectures. The | ||
| one is available. Migrate-ease is one pinned source archive used by both architectures. The |
brikin01
reviewed
Aug 27, 2026
| argument-hint: '[local workspace or GitHub repo URL] [--apply-fixes optional]' | ||
| agent: 'agent' | ||
| tools: ['search/codebase', 'search/fileSearch', 'search/textSearch', 'search/listDirectory', 'edit/editFiles', 'execute/runInTerminal', 'execute/getTerminalOutput', 'read/terminalLastCommand', 'arm-mcp/skopeo', 'arm-mcp/check_image', 'arm-mcp/knowledge_base_search', 'arm-mcp/migrate_ease_scan', 'arm-mcp/mca', 'arm-mcp/apx_recipe_run', 'arm-mcp/sysreport_instructions'] | ||
| tools: ['search/codebase', 'search/fileSearch', 'search/textSearch', 'search/listDirectory', 'edit/editFiles', 'execute/runInTerminal', 'execute/getTerminalOutput', 'read/terminalLastCommand', 'arm-mcp/skopeo', 'arm-mcp/check_image', 'arm-mcp/knowledge_base_search', 'arm-mcp/migrate_ease_scan', 'arm-mcp/mca', 'arm-mcp/sysreport_instructions'] |
Collaborator
There was a problem hiding this comment.
Should we revisit tools: for all of these VSCode prompts? To my understanding, in VS Code, the prompt’s tool list takes precedence over default agent tools, so installed Performix tools and/or the terminal needed for the perf fallback may be unavailable.
Possible options:
- Omit
tools:entirely to inherit all enabled Agent/MCP tools. - Add
performix/*and the terminal tool explicitly (assuming that's the name of the MCP) - Omit
tools:and use#tool:references in the body to recommend tools without restricting others.
Comment on lines
17
to
22
| * Confirm runtime context before profiling: | ||
| * Try to infer the workload command, target host/IP, SSH username, and whether the target is localhost or remote. Confirm before running. Use absolute paths. Here are some examples of the value to pass for the cmd parameter: | ||
| * For C++ code: `/home/user/arm-migration-example/benchmark` | ||
| * For Python code: `python /home/user/workspace/train.py` | ||
| * For Java: `java -cp "absolute/path/to/class" some.package.Main` | ||
| * If localhost is requested, use `localhost` as the remote_ip. |
Collaborator
There was a problem hiding this comment.
Some of this guidance seems closely tied to the removed apx_recipe_run interface, including cmd and remote_ip. Would it be better for these prompts to describe the required outcome (i.e. identify the workload, select or configure an appropriate target, and run the recipe) while deferring the exact parameters and target workflow to the connected Performix tooling?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: there are some upstream registry and documentation changes that still need to be done outside this repo, which I will do separately.