feat(#4466): support optdepends of linux-firmware - #4712
Conversation
|
Can we add some preview with minimal description for these |
|
@h8d13 can we address #4712 (comment) |
|
I think I did change it to I'll check again it's been a while and needs rebase (and testing on the actual hardware perhaps? Which I don't own much of). |
|
I meant adding a preview with short descriptions |
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
* dont touch other stuff Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
|
Idk what happened to my git log there apologies but the edits should be in. Didn't touch |
|
LGTM but it has conflicts with another merged PR |
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
|
Had to add to test config since #4709 I always read "LGTM" as "legitimate" in my head 🤣 |
|
Why not detect user's hardware and install automatically? How can I know that which one I need? |
|
That is what I initially planned. But its much harder. For instance some hardware changes IDs on OEM merges. As to "why" it's stated in the PR body. If you want to take a look here: https://github.com/h8d13/archinstoo/blob/master/installer/archinstoo/lib/hardware.py The logic gets much more complex. And isn't really suited for here. Keep in mind I maintain this solo. You can find out by simply looking up what's inside your computer. |
|
If running "hwdetect" in the live arch iso possible then this may help with making the choice too. (I didn't try it before though, let me try how much info hwdetect shows.) |
Follow up to discussion #4466
Instead of adding PCIDs detection or touching any existing logic; simply expose the optional set for user to select. Goal was to reduce maintain burden as this simply needs to track new
optdependsThis is then strapped at
_base_packagesas an.extend()before themkinitcpio -Pcall.Since it's fully optional, to me it should not be gated behind
--advanced, we initialize as empty[]and extend selections.This would notably make some Marvell Wifi card users happy (i,e surface type devices) and QCOM being quite common nowadays. The others, I've had little experience with.
https://wiki.archlinux.org/title/Linux_firmware#Installation