Skip to content

feat(#4466): support optdepends of linux-firmware - #4712

Merged
svartkanin merged 11 commits into
archlinux:masterfrom
h8d13:dot-pcids
Sep 29, 2026
Merged

svartkanin merged 11 commits into
archlinux:masterfrom
h8d13:dot-pcids

Conversation

@h8d13

@h8d13 h8d13 commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Follow up to discussion #4466

Screenshot_20260812_140313

Instead of adding PCIDs detection or touching any existing logic; simply expose the optional set for user to select. Goal was to reduce maintain burden as this simply needs to track new optdepends

This is then strapped at _base_packages as an .extend() before the mkinitcpio -P call.
Since it's fully optional, to me it should not be gated behind --advanced, we initialize as empty [] and extend selections.

This would notably make some Marvell Wifi card users happy (i,e surface type devices) and QCOM being quite common nowadays. The others, I've had little experience with.

https://wiki.archlinux.org/title/Linux_firmware#Installation

@h8d13
h8d13 requested a review from Torxed as a code owner August 12, 2026 12:21
@svartkanin

Copy link
Copy Markdown
Collaborator

Can we add some preview with minimal description for these

Comment thread archinstall/lib/global_menu.py Outdated
Comment thread archinstall/lib/global_menu.py Outdated
@svartkanin

Copy link
Copy Markdown
Collaborator

@h8d13 can we address #4712 (comment)

@h8d13

h8d13 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor Author

I think I did change it to Additional already (at least user facing wording), left internal as is.

I'll check again it's been a while and needs rebase (and testing on the actual hardware perhaps? Which I don't own much of).

@svartkanin

Copy link
Copy Markdown
Collaborator

I meant adding a preview with short descriptions

Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
* dont touch other stuff

Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
Signed-off-by: h8d13 <hadean-eon-dev@proton.me>
@h8d13

h8d13 commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

Idk what happened to my git log there apologies but the edits should be in. Didn't touch tr translation files for these new entries.

@svartkanin

Copy link
Copy Markdown
Collaborator

LGTM but it has conflicts with another merged PR

@h8d13

h8d13 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Had to add to test config since #4709

I always read "LGTM" as "legitimate" in my head 🤣

@svartkanin
svartkanin merged commit 78982a6 into archlinux:master Sep 29, 2026
11 checks passed
@sidalsolgun

Copy link
Copy Markdown

Why not detect user's hardware and install automatically?

How can I know that which one I need?

@h8d13
h8d13 deleted the dot-pcids branch September 29, 2026 20:55
@h8d13

h8d13 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor Author

That is what I initially planned. But its much harder. For instance some hardware changes IDs on OEM merges. As to "why" it's stated in the PR body.

If you want to take a look here:

https://github.com/h8d13/archinstoo/blob/master/installer/archinstoo/lib/hardware.py

The logic gets much more complex. And isn't really suited for here. Keep in mind I maintain this solo.

You can find out by simply looking up what's inside your computer.

@sidalsolgun

Copy link
Copy Markdown

If running "hwdetect" in the live arch iso possible then this may help with making the choice too.

(I didn't try it before though, let me try how much info hwdetect shows.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants