feat: SDK update for version 15.5.0 - #106
Conversation
Greptile SummaryUpdates the Console SDK to version 15.5.0.
Confidence Score: 3/5The PR should not merge until the retained updateOAuth2Server positional overload preserves the existing argument positions. Inserting the new duration argument before confidentialPkce shifts every trailing positional setting, causing compile failures for typed consumers and incorrectly constructed payloads for JavaScript consumers. src/services/project.ts Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
src/services/project.ts:1011
**Positional OAuth settings shift**
When existing consumers use the retained positional `updateOAuth2Server` overload, the new duration parameter takes the former `confidentialPkce` position and shifts every later argument, causing TypeScript compilation failures or JavaScript requests that send OAuth2 settings under the wrong payload fields.
Reviews (1): Last reviewed commit: "Merge main into dev for 15.5.0 release" | Re-trigger Greptile |
| * @deprecated Use the object parameter style method for a better developer experience. | ||
| */ | ||
| updateOAuth2Server(enabled: boolean, authorizationUrl: string, scopes?: string[], authorizationDetailsTypes?: string[], accessTokenDuration?: number, refreshTokenDuration?: number, publicAccessTokenDuration?: number, publicRefreshTokenDuration?: number, confidentialPkce?: boolean, verificationUrl?: string, userCodeLength?: number, userCodeFormat?: string, deviceCodeDuration?: number, defaultScopes?: string[]): Promise<Models.Project>; | ||
| updateOAuth2Server(enabled: boolean, authorizationUrl: string, scopes?: string[], authorizationDetailsTypes?: string[], accessTokenDuration?: number, refreshTokenDuration?: number, publicAccessTokenDuration?: number, publicRefreshTokenDuration?: number, installationAccessTokenDuration?: number, confidentialPkce?: boolean, verificationUrl?: string, userCodeLength?: number, userCodeFormat?: string, deviceCodeDuration?: number, defaultScopes?: string[]): Promise<Models.Project>; |
There was a problem hiding this comment.
Positional OAuth settings shift
When existing consumers use the retained positional updateOAuth2Server overload, the new duration parameter takes the former confidentialPkce position and shifts every later argument, causing TypeScript compilation failures or JavaScript requests that send OAuth2 settings under the wrong payload fields.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/services/project.ts
Line: 1011
Comment:
**Positional OAuth settings shift**
When existing consumers use the retained positional `updateOAuth2Server` overload, the new duration parameter takes the former `confidentialPkce` position and shifts every later argument, causing TypeScript compilation failures or JavaScript requests that send OAuth2 settings under the wrong payload fields.
How can I resolve this? If you propose a fix, please make it concise.
This PR contains updates to the SDK for version 15.5.0.
What's Changed
projects.createDevKey()methodappskey management methodslistKeys,createKey,getKey,deleteKey, andlistInstallationScopesinstallationScopesandinstallationRedirectUrlparameters toapps.update()organizationandteamsservicesinstallationAccessTokenDurationparameter toproject.updateOAuth2Server()vectorsDB.createQuery()for querying documents via POST request body