Conversation
tfpauly
requested review from
agnosticdev,
ekinnear,
kkuk24 and
rpaulo
as code owners
September 17, 2026 19:52
agnosticdev
reviewed
Sep 17, 2026
| // the request and let the ACK path flush once its borrow has ended. | ||
| if isProcessingAcks { | ||
| deferredSendFramesRequested = true | ||
| return false |
Collaborator
There was a problem hiding this comment.
So there must have been an overlapping access with Recovery here?
Collaborator
There was a problem hiding this comment.
Confirmed that this was a defensive check
agnosticdev
approved these changes
Sep 17, 2026
kkuk24
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that flow control credit doesn't get lost/dropped if a stream is forcibly closed before the application has read the outstanding data