fix(basic): settle teardown during crawler startup - #4094
Open
miakh wants to merge 4 commits into
Open
Conversation
janbuchar
self-requested a review
September 1, 2026 14:37
…-during-startup # Conflicts: # packages/basic-crawler/src/internals/basic-crawler.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teardown()requests across the wholeBasicCrawler.run()initialization phaseAutoscaledPoolafter teardown has already completedrun()does not affect the next runThe cancellation state belongs to
BasicCrawler, which owns the completerun()/teardown()lifecycle. This keepsAutoscaledPoolbehavior unchanged.Validation
pnpm vitest run test/core/crawlers/basic_crawler.test.ts --silent(160 passed)pnpm exec tsc --noEmit --project test/tsconfig.jsonpnpm --filter @crawlee/basic compilepnpm format:checkCloses #4080