fix(core): preserve request error messages without stacks - #4092
Open
lprnmns wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Request.pushErrorMessage()can appendnullorundefinedwhen anErrorhas no stack.errorMessagesis a persistedstring[], so the invalid entry can make request reconstruction/persistence fail.When a stack is unavailable, preserve the existing message as the fallback. This keeps stack-rich errors unchanged and prevents malformed error-message arrays.
Fixes #4087
Testing
corepack pnpm exec vitest run test/core/request.test.ts --coverage.enabled=falsecorepack pnpm exec oxfmt --check packages/core/src/request.ts test/core/request.test.tscorepack pnpm exec oxlint packages/core/src/request.ts test/core/request.test.ts --tsconfig=tsconfig.json --type-awareThe full test TypeScript check was also attempted; it is currently blocked in a pristine checkout by pre-existing missing generated
@crawlee/*/distdeclarations and unrelated strictness errors.