fix(core): stop scanning handled requests in the in-memory request queue - #4083
Open
vladfrangu wants to merge 2 commits into
Open
fix(core): stop scanning handled requests in the in-memory request queue#4083vladfrangu wants to merge 2 commits into
vladfrangu wants to merge 2 commits into
Conversation
github-actions
Bot
added
t-tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-memory request queue kept handled requests in the same
Mapit walked on every head scan, sofetchNextRequest,isEmptyandisFinishedwere O(handled) per call and draining a queue was O(N²). With 450k handled requests each call took ~200ms (~1.4s per add/fetch/handle cycle), the in-memory counterpart of #2406.Handled requests now stay in
requestsfor deduplication only; a separate insertion-orderedpendingRequestIdsset holds the unhandled ids and is what the head scan iterates. Ordering is unchanged, since the set mirrors the map's insertion order for those ids.Closes #2406 — the file-system backend is no longer affected either, since the Rust
@crawlee/fs-storage-nativeclient only scans the directory once onopen().[🤖] Claude Code using Fable 5