refactor!: remove persistState from IRequestLoader interface - #4042
Open
harryautomazione wants to merge 2 commits into
Open
refactor!: remove persistState from IRequestLoader interface#4042harryautomazione wants to merge 2 commits into
harryautomazione wants to merge 2 commits into
Conversation
harryautomazione
force-pushed
the
fix/remove-persist-state-from-irequestloader
branch
5 times, most recently
from
August 16, 2026 10:19
8d7915f to
da8490f
Compare
B4nan
force-pushed
the
fix/remove-persist-state-from-irequestloader
branch
from
August 18, 2026 18:24
da8490f to
a5be40b
Compare
Member
|
heads up: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persistStatefromIRequestList#3721persistState?(): Promise<void>fromIRequestLoaderinterface (andIRequestManager), as loader implementations handle state persistence internally by listening toEventType.PERSIST_STATEevents (e.g. viaRecoverableStateorEventManager).validators.requestListschema invalidators.tsto validate['fetchNextRequest', 'isFinished']instead of requiringpersistState.persistStateinvocation inThrottlingRequestManager.persistState().@crawlee/corepublic API snapshot indocs/public-api/crawlee-core.api.md.