Skip to content

refactor!: remove persistState from IRequestLoader interface - #4042

Open
harryautomazione wants to merge 2 commits into
apify:masterfrom
harryautomazione:fix/remove-persist-state-from-irequestloader
Open

refactor!: remove persistState from IRequestLoader interface#4042
harryautomazione wants to merge 2 commits into
apify:masterfrom
harryautomazione:fix/remove-persist-state-from-irequestloader

Conversation

@harryautomazione

Copy link
Copy Markdown
Contributor
  • Closes Remove persistState from IRequestList #3721
  • Follow-up to refactor!: Finalize transition to IRequestManager and IRequestLoader #3719
  • Removed persistState?(): Promise<void> from IRequestLoader interface (and IRequestManager), as loader implementations handle state persistence internally by listening to EventType.PERSIST_STATE events (e.g. via RecoverableState or EventManager).
  • Updated validators.requestList schema in validators.ts to validate ['fetchNextRequest', 'isFinished'] instead of requiring persistState.
  • Duck-typed persistState invocation in ThrottlingRequestManager.persistState().
  • Updated @crawlee/core public API snapshot in docs/public-api/crawlee-core.api.md.

@harryautomazione
harryautomazione force-pushed the fix/remove-persist-state-from-irequestloader branch 5 times, most recently from 8d7915f to da8490f Compare August 16, 2026 10:19
@B4nan
B4nan changed the base branch from v4 to master August 18, 2026 16:33
@B4nan
B4nan force-pushed the fix/remove-persist-state-from-irequestloader branch from da8490f to a5be40b Compare August 18, 2026 18:24
@B4nan

B4nan commented Aug 18, 2026

Copy link
Copy Markdown
Member

heads up: the v4 branch was merged into master (v3 development moved to the 3.x branch), so I rebased this branch onto master and force-pushed it to your fork. Your commits are unchanged, just replayed on the new base. Before adding more changes, reset your local branch to the remote one (e.g. git fetch && git reset --hard @{u}), otherwise you'd reintroduce the old history.

@B4nan B4nan changed the title refactor!: remove persistState from IRequestLoader interface (#3721) refactor!: remove persistState from IRequestLoader interface Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove persistState from IRequestList

3 participants