fix: Require unique_key and url in RequestBase, add RequestWithoutId - #1030
Merged
Merged
Conversation
apify-service-account
added
the
t-tooling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1030 +/- ##
=======================================
Coverage 94.95% 94.96%
=======================================
Files 58 58
Lines 5436 5439 +3
=======================================
+ Hits 5162 5165 +3
Misses 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Splits this PR down to the request-queue changes only. The pricing_infos and apify_margin_percentage changes are unrelated and will come back as their own PR on the next model-sync run.
vdusek
changed the title
vdusek
approved these changes
Aug 24, 2026
vdusek
added a commit
that referenced
this pull request
Aug 25, 2026
…ID (#1032) Master CI is red on every type-check and unit-test job: https://github.com/apify/apify-client-python/actions/runs/32821686073 Two PRs that each passed CI on their own conflict semantically once merged together: - #1030 made `unique_key` a required field on `RequestBase`. - #1025 added two tests that build `Request(url='https://example.com')` to assert `update_request` rejects a request with no ID. In that order, the `Request` constructor now raises a pydantic `ValidationError` for the missing `uniqueKey` before `update_request` is ever reached — so `ty` reported 2 `missing-argument` diagnostics and both tests failed on the wrong exception. Supplying the now-required `unique_key` makes the tests exercise what they were written for (the missing ID), not model validation. *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.toml.v2-2026-08-14T072928Z->v2-2026-08-24T085852Z.Important
Retitle this pull request to
fix:orfeat:when the diff is user-facing, so that it lands in the changelog and triggers a release -chore:does neither.